Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent empty team name submission [WPB-15274] #18754

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Feb 14, 2025

TaskWPB-15274 [Web] Do not allow empty Team name from the UI

Description

Fixes the issue where user can type empty team name or white spaces in personal to team migration.

Screenshots/Screencast (for UI changes)

Before

issue-WPB-15274

After

fix-WPB-15274 fix1-WPB-15274

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (eba169a) to head (5c48112).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18754      +/-   ##
==========================================
- Coverage   45.66%   45.65%   -0.01%     
==========================================
  Files         968      968              
  Lines       27938    27944       +6     
  Branches     6303     6304       +1     
==========================================
  Hits        12757    12757              
- Misses      13591    13595       +4     
- Partials     1590     1592       +2     

@waseemansar waseemansar merged commit ec64ace into dev Feb 14, 2025
15 checks passed
@waseemansar waseemansar deleted the fix/empty-team-name-WPB-15274 branch February 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants