-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(InputBar): split logic into hooks and components #18753
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18753 +/- ##
==========================================
+ Coverage 45.64% 45.70% +0.05%
==========================================
Files 968 988 +20
Lines 27939 28038 +99
Branches 6303 6313 +10
==========================================
+ Hits 12754 12814 +60
- Misses 13596 13632 +36
- Partials 1589 1592 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement! 🚀
Description
Reason:
InputBar
scope, I'd like to work more seamlesslyScope:
useDraftState
,usePing
,useGihpy
,useFileHandling
...InputBarButtons
,InputBarContainer
...Rules:
Checklist