runfix: emojis picker click outside and search clear button background [WPB-16145] #18750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-maad
approved these changes
Feb 14, 2025
| @@ -754,7 +754,7 @@ export const VideoControls: React.FC<VideoControlsProps> = ({ | |||
| <EmojisBar | |||
| onEmojiClick={handleEmojiClick} | |||
| onPickerEmojiClick={() => setShowEmojisBar(false)} | |||
| detachedWindow={detachedWindow} | |||
| targetWindow={viewMode === CallingViewMode.DETACHED_WINDOW ? detachedWindow! : window} | |||
There was a problem hiding this comment.
Can we create a variable for it?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18750 +/- ##
==========================================
- Coverage 45.64% 45.64% -0.01%
==========================================
Files 968 968
Lines 27939 27939
Branches 6303 6304 +1
==========================================
- Hits 12754 12753 -1
Misses 13596 13596
- Partials 1589 1590 +1 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the click outside handling for emojis picker in full screen view and hover background from emoji picker search clear button in dark mode.
Screenshots/Screencast (for UI changes)
fixes.mov
Checklist