Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show modal to encourage reloading when mls is enabled (WPB-15566) #18744

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Feb 12, 2025

BugWPB-15566 [Web] Web does not create MLS clients unless page reloaded after MLS is set as supported for team

Description

Will show a modal encouraging user to reload the app when mls is enabled on their team.

telegram-cloud-photo-size-4-5866059066248381930-y

Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Please make sure to have an opinion from designer, I would prefer blue over red color.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (2cfb59d) to head (db0c1e3).
Report is 19 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18744      +/-   ##
==========================================
- Coverage   45.61%   45.61%   -0.01%     
==========================================
  Files         956      974      +18     
  Lines       27865    27982     +117     
  Branches     6288     6314      +26     
==========================================
+ Hits        12712    12763      +51     
- Misses      13566    13627      +61     
- Partials     1587     1592       +5     

@thisisamir98 thisisamir98 merged commit 0fd5b7e into dev Feb 17, 2025
15 checks passed
@thisisamir98 thisisamir98 deleted the WPB-15566 branch February 17, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants