Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: correct group icon dark mode background color [WPB-15794] #18742

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Feb 12, 2025

StoryWPB-15794 [Web] Adjust group avatars (not channels) to be in line with channel mocks

Description

correct group icon dark mode background color

Screenshots/Screencast (for UI changes)

Before:
image

After:
image

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Added one suggestion, if you like to cater.

// ----------------------------------------------------------------------------
@sidebar-bg: var(--gray-20);
@sidebar-border-color: var(--gray-50);
@sidebar-folder-selected-bg: var(--gray-30);
@conversation-list-bg-opacity: fade(#000, 64%);
@sidebar-box-shadow: #eee;
@sidebar-box-shadow-lg: rgba(0, 0, 0, 0.12);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we remove them, as they are not in use anymore.

sidebar-box-shadow
sidebar-box-shadow-lg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% 👍

V-Gira and others added 2 commits February 12, 2025 13:09
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
@V-Gira V-Gira merged commit 2cfb59d into dev Feb 12, 2025
14 of 15 checks passed
@V-Gira V-Gira deleted the v/group-icon-bg branch February 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants