-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runfix: correct group icon dark mode background color [WPB-15794] #18742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Added one suggestion, if you like to cater.
src/style/foundation/themes.less
Outdated
// ---------------------------------------------------------------------------- | ||
@sidebar-bg: var(--gray-20); | ||
@sidebar-border-color: var(--gray-50); | ||
@sidebar-folder-selected-bg: var(--gray-30); | ||
@conversation-list-bg-opacity: fade(#000, 64%); | ||
@sidebar-box-shadow: #eee; | ||
@sidebar-box-shadow-lg: rgba(0, 0, 0, 0.12); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we remove them, as they are not in use anymore.
sidebar-box-shadow
sidebar-box-shadow-lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% 👍
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik96@gmail.com>
|
Description
correct group icon dark mode background color
Screenshots/Screencast (for UI changes)
Before:

After:

Checklist