Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatic Video Quality Adjustments [WPB-11479] #18253

Merged
merged 15 commits into from
Dec 4, 2024

Conversation

EnricoSchw
Copy link
Contributor

@EnricoSchw EnricoSchw commented Oct 31, 2024

StoryWPB-11479 [Web] Simulcast Support & Automatic Quality Adjustments

BugWPB-11479 [Web] Simulcast Support & Automatic Quality Adjustments

Description

To save bandwidth and improve the overall experience, the video quality requested by the client depends on the size and requirements of the display.

Checklist

  • mentions the JIRA issue in the PR name (Ex. WPB-423)
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@EnricoSchw EnricoSchw changed the title feat: Automatic Quality Adjustments [WPB-11479] feat: Automatic Video Quality Adjustments [WPB-11479] Oct 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 24.32432% with 56 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (391f8ba) to head (0fe540c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18253      +/-   ##
==========================================
- Coverage   46.45%   46.38%   -0.08%     
==========================================
  Files         844      844              
  Lines       26216    26283      +67     
  Branches     5939     5956      +17     
==========================================
+ Hits        12179    12191      +12     
- Misses      12516    12565      +49     
- Partials     1521     1527       +6     

@EnricoSchw EnricoSchw marked this pull request as ready for review November 11, 2024 16:18
@EnricoSchw EnricoSchw requested review from otto-the-bot and a team as code owners November 11, 2024 16:18
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 20, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@EnricoSchw EnricoSchw merged commit ce47d8f into dev Dec 4, 2024
13 checks passed
@EnricoSchw EnricoSchw deleted the feat/WPB-11479-simulcast branch December 4, 2024 14:10
V-Gira added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: calling echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M type: feature / request ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants