runfix: device modal update #16409
Merged
runfix: device modal update #16409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16409 +/- ##
=======================================
Coverage 45.50% 45.50%
=======================================
Files 736 736
Lines 23974 23973 -1
Branches 5453 5452 -1
=======================================
Hits 10909 10909
Misses 11665 11665
+ Partials 1400 1399 -1 |
atomrc
reviewed
Dec 20, 2023
Comment on lines
176
to
-178
| {t('modalAccountNewDevicesMessage')} | ||
| <div className="modal__content__device-list">${deviceList}</div> |
There was a problem hiding this comment.
is it normal that the order of those 2 elements changed? 🤔
There was a problem hiding this comment.
its intentional. you can see the previous order of the elements in the screenshot
atomrc
reviewed
Dec 20, 2023
Comment on lines
-169
to
-170
| <div>${formattedDate} - UTC</div> | ||
| <div>${deviceModel}</div> |
There was a problem hiding this comment.
Ahh this was a string before, right? Nice
atomrc
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
device modal fix
Screenshots/Screencast (for UI changes)
Checklist