refactor: Do not rely on amplify for sound notifications #16408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Dec 20, 2023
| @@ -766,12 +768,12 @@ export class NotificationRepository { | |||
| if (shouldPlaySound) { | |||
| switch (messageEntity.super_type) { | |||
| case SuperType.CONTENT: { | |||
| amplify.publish(WebAppEvents.AUDIO.PLAY, AudioType.NEW_MESSAGE); | |||
| void this.audioRepository.play(AudioType.NEW_MESSAGE); | |||
There was a problem hiding this comment.
We now have direct calls to the audio repo (rather than implicit global events)
| break; | ||
| } | ||
|
|
||
| case SuperType.PING: { | ||
| amplify.publish(WebAppEvents.AUDIO.PLAY, AudioType.INCOMING_PING); | ||
| void this.audioRepository.play(AudioType.INCOMING_PING); |
There was a problem hiding this comment.
We now have direct calls to the audio repo (rather than implicit global events)
| @@ -240,7 +242,7 @@ export class MessageRepository { | |||
| legalHoldStatus: conversation.legalHoldStatus(), | |||
| }); | |||
|
|
|||
| amplify.publish(WebAppEvents.AUDIO.PLAY, AudioType.OUTGOING_PING); | |||
| void this.audioRepository.play(AudioType.OUTGOING_PING); | |||
There was a problem hiding this comment.
We now have direct calls to the audio repo (rather than implicit global events)
| repositories.notification = new NotificationRepository( | ||
| repositories.conversation, | ||
| repositories.permission, | ||
| repositories.audio, |
There was a problem hiding this comment.
It's not explicit that the notification repo will trigger sound
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16408 +/- ##
==========================================
- Coverage 45.49% 45.49% -0.01%
==========================================
Files 736 735 -1
Lines 23974 23966 -8
Branches 5453 5449 -4
==========================================
- Hits 10908 10904 -4
+ Misses 11666 11663 -3
+ Partials 1400 1399 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the implicit and untyped dependency between the
AudioRepositoryand other Repositories.This should streamline and make it easier to understand what triggers sound in the app
Checklist