Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: missing message text on modal #16407

Merged
merged 1 commit into from
Dec 20, 2023
Merged

runfix: missing message text on modal #16407

merged 1 commit into from
Dec 20, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Dec 20, 2023

Description

missing messages on modals with new modal updates

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (59addd3) 45.49% compared to head (35172e3) 45.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #16407   +/-   ##
=======================================
  Coverage   45.49%   45.50%           
=======================================
  Files         736      736           
  Lines       23974    23974           
  Branches     5453     5453           
=======================================
+ Hits        10908    10909    +1     
+ Misses      11666    11665    -1     
  Partials     1400     1400           

@tlebon tlebon merged commit 6129bd6 into dev Dec 20, 2023
8 checks passed
@tlebon tlebon deleted the fix/modal-missing-message branch December 20, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants