feat: E2EI SoftLock #16406
feat: E2EI SoftLock #16406
Conversation
| @@ -262,10 +262,12 @@ export class E2EIHandler extends TypedEventEmitter<Events> { | |||
| this.currentStep = E2EIHandlerStep.INITIALIZED; | |||
| } | |||
|
|
|||
| const isFreshMLSSelfClient = void this.coreE2EIService.isFreshMLSSelfClient(); | |||
There was a problem hiding this comment.
This is very weird, voiding the result of the function will always yield undefined
There was a problem hiding this comment.
Yee.. I see, looking for issue :)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16406 +/- ##
==========================================
- Coverage 45.53% 45.48% -0.05%
==========================================
Files 735 736 +1
Lines 24021 24054 +33
Branches 5455 5466 +11
==========================================
+ Hits 10938 10942 +4
- Misses 11686 11713 +27
- Partials 1397 1399 +2 |
src/i18n/en-US.json
Outdated
| @@ -71,6 +71,10 @@ | |||
| "E2EI.updateCertificate": "Update Certificate", | |||
| "E2EI.valid": "Valid", | |||
| "E2EI.verified": "Verified (End-to-end Identity)", | |||
| "E2EI.SoftLock.Heading": "End-to-end identity certificate", | |||
| "E2EI.SoftLock.Content": "Your team now uses end-to-end identity to make Wire’s usage more secure. The device verification takes place automatically using a certificate.<br /><br />Enter your identity provider’s credentials in the next step to automatically get a verification certificate for this device.", | |||
There was a problem hiding this comment.
There should not be html in our translations.
We should split this into multiple translation keys
There was a problem hiding this comment.
It's not used. Forgot to remove it.
| const isFreshMLSSelfClient = await this.coreE2EIService.isFreshMLSSelfClient(); | ||
|
|
||
| this.showE2EINotificationMessage(isFreshMLSSelfClient); |
There was a problem hiding this comment.
Let's save this info in the config (since it's passed to initialize) and avoid recomputing it (or do we need to recompute it at this point?)
| gracePeriodExpiredCallback: () => { | ||
| this.showE2EINotificationMessage(); | ||
| gracePeriodExpiredCallback: async () => { | ||
| const isFreshMLSSelfClient = await this.coreE2EIService.isFreshMLSSelfClient(); |
There was a problem hiding this comment.
can't we use the freshMLSSelfClient prop?
| delayPeriodExpiredCallback: () => { | ||
| this.showE2EINotificationMessage(); | ||
| delayPeriodExpiredCallback: async () => { | ||
| const isFreshMLSSelfClient = await this.coreE2EIService.isFreshMLSSelfClient(); |
There was a problem hiding this comment.
can't we use the freshMLSSelfClient prop?
Description
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)