fix: use local users if they cannot be loaded from BE [WPB-5959] #16405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16405 +/- ##
==========================================
+ Coverage 45.48% 45.49% +0.01%
==========================================
Files 736 734 -2
Lines 23972 23945 -27
Branches 5454 5442 -12
==========================================
- Hits 10903 10894 -9
+ Misses 11669 11656 -13
+ Partials 1400 1395 -5 |
4e789df to
d6ecc63
Compare
PatrykBuniX
commented
Dec 21, 2023
Comment on lines
+606
to
+613
| const dbUserRecord = dbUsers?.find(user => matchQualifiedIds(user.qualified_id, userId)); | ||
|
|
||
| if (dbUserRecord && selfUser) { | ||
| return this.userMapper.mapUserFromJson(dbUserRecord, selfDomain); | ||
| } | ||
|
|
||
| // Otherwise, we generate placeholder users locally with some default values. | ||
| return new User(userId.id, userId.domain); |
There was a problem hiding this comment.
Before returning a placeholder for "unavailable user" we try looking it up in local indexedDB because there's a chance that we've already saved this user before.
atomrc
approved these changes
Dec 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initially loading a list of users, it can happen that one of the federated backends is offline (unreachable), therefore we will not receive fresh user data from the server. It's possible that we've already fetched this user before, thus we can try looking it up in local db (indexedDB) before just returning a placeholder for "unavailable user".
Checklist