Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: Do not show MLS verification state for proteus devices #16404

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Dec 20, 2023

Description

Differenciate proteus-only devices from MLS basic devices in the verification badges of a user's devices

Screenshots/Screencast (for UI changes)

image

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (93da4be) 45.48% compared to head (c3a823b) 45.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16404      +/-   ##
==========================================
+ Coverage   45.48%   45.49%   +0.01%     
==========================================
  Files         736      736              
  Lines       23972    23974       +2     
  Branches     5454     5453       -1     
==========================================
+ Hits        10903    10908       +5     
+ Misses      11669    11666       -3     
  Partials     1400     1400              

@atomrc atomrc force-pushed the runfix/proteus-shields branch from b957b91 to 410906f Compare December 20, 2023 11:38
@atomrc atomrc force-pushed the runfix/proteus-shields branch from 410906f to c3a823b Compare December 20, 2023 11:51
@atomrc atomrc merged commit 59addd3 into dev Dec 20, 2023
@atomrc atomrc deleted the runfix/proteus-shields branch December 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants