Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-client): cells api [WPB-16108] #6960

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(api-client): cells api [WPB-16108] #6960

wants to merge 22 commits into from

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Feb 25, 2025 •
edited
Loading

Description

Implements cells-sdk-ts inside the api-client package. Cells will change in the future, due to backend changes, for now, this implementation will be used for testing and MVP.

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@olafsulich
test(CellsAPI): remove unnecessary comment in MockFile
56409b5
@olafsulich
fix: tests
b7312b0
@olafsulich
fix(APIClient): tests
2d685ce
@olafsulich
fix(CellsAPI): remove unnecessary configuration validation
be8d096
@olafsulich
fix: tests
75f3871
@olafsulich
refactor(CellsAPI): rename cellsConfig parameter to config
90ca47c
@olafsulich
refactor(CellsAPI): update test configuration and HttpClient config a…
d2bd6dc 
…ccess
@olafsulich
test(APIClient): update test configuration and use mock test config
d2c8f2e
@olafsulich
refactor(APIClient): make CellsAPI optional and update initialization…
7f30692 
… logic
@olafsulich
feat(CellsAPI): add file draft and public link management methods
ee45aba
@olafsulich
refactor(S3Service): simplify AWS credentials configuration
432d26a
@olafsulich
feat(CellsAPI): update deleteFile method to return action response
bc16c4a
@olafsulich
fix(HttpClient): add missing headers for the axios config
ce3406a
@olafsulich
feat(APIClient): make cells non optional
7199fbd
@olafsulich
chore: update gitignore to ignore yalc files
6f7b80c
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 26, 2025
View reviewed changes
@olafsulich olafsulich marked this pull request as ready for review February 26, 2025 09:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olafsulich @otto-the-bot