-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write the output to the $GITHUB_OUTPUT file #17
Write the output to the $GITHUB_OUTPUT file #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I didn't notice deprecations. Except env reference, lgtm!
Co-authored-by: winterjung <me@winterjung.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🚀 Do you plan on creating a new release soon? |
@john-jam Sure. I have been released |
I am still hitting the warning but I guess it's because of the docker image (v2 tag) not yet updated. |
@john-jam I pushed docker image with |
This is a breaking change lol |
@RobKenis Thanks for reporting. I didn't notice it's breaking changes. 🥲 Could you add more some details for me to resolve problem? (environment, usage of hosted runner, etc.) |
These are the logs from the step
We are using a hosted runner, running in an alpine-based container. |
Can you log a deprecation warning for |
This PR writes the output to the $GITHUB_OUTPUT file instead of echoing to stdout (see deprecation notes here).
Not 100% sure we have access to this file from within the container though.