Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Winter\Storm\Translation\Translator::set does not exist #480

Closed
Tracked by #148
zimbar opened this issue Mar 2, 2022 · 3 comments
Closed
Tracked by #148

Method Winter\Storm\Translation\Translator::set does not exist #480

zimbar opened this issue Mar 2, 2022 · 3 comments
Milestone

Comments

@zimbar
Copy link

zimbar commented Mar 2, 2022

Winter CMS Build

1.1

PHP Version

7.3

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

Hy,

I want to install the plugin "mall by offline", but i have this error during installation "Method Winter\Storm\Translation\Translator::set does not exist"

Thanks

Steps to replicate

go to settings->update&plugins->install plugin->search for "mall by offline"

Workaround

No response

@zimbar zimbar added needs review Issues/PRs that require a review from a maintainer Type: Unconfirmed Bug labels Mar 2, 2022
@LukeTowers
Copy link
Member

This stems from the plugin in question using octobercms/library@20ccbe7 which was added to October but not to Winter.

@LukeTowers LukeTowers added the third party Issues/PRs that are dependent on changes made to a third-party library label Mar 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label May 2, 2022
@LukeTowers LukeTowers removed the stale Issues/PRs that have had no activity and may be archived label May 2, 2022
@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes and removed Type: Unconfirmed Bug third party Issues/PRs that are dependent on changes made to a third-party library needs review Issues/PRs that require a review from a maintainer labels Jun 28, 2022
@LukeTowers LukeTowers added this to the v1.2.0 milestone Jun 28, 2022
LukeTowers added a commit to wintercms/storm that referenced this issue Jun 28, 2022
Bring Translator closer to base Laravel functionality, add "set" method, remove translator.beforeResolve event.

Fixes wintercms/winter#480
@bennothommo
Copy link
Member

Fixed by wintercms/storm#91

@bennothommo bennothommo removed the maintenance PRs that fix bugs, are translation changes or make only minor changes label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants