Load deferred providers before provider registration #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thought it was going to be needed for the tests, but ended up not needing it.
LukeTowers
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
@bennothommo if you've tested with the latest 1.2 of the system module and it works fine in the web environment I'm happy to have this merged, seems like a pretty great solution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements laravel/framework#38724 into the Winter codebase, extending the base Laravel ProviderRepository class and overriding the
loadmethod. Reverts dff4e6e and partially reverts 6d95046.This PR will override the base provider loading functionality to record deferred providers before registering any eager loaded providers. This allows eager loaded providers to use deferred provider functionality (such as the Cache provider). In this method, this will technically make those providers eager loaded as well, but these providers will be deferred if no other provider uses them in registration.