[WIP v1.2] Add full compatibility with Symfony\Yaml 4.4 #21
Conversation
|
@LukeTowers can you merge this to fix the yaml files parsing? Thanks. |
|
Can you add tests for what happens if single and double quotes appear in the unquoted values? |
|
@LukeTowers You mean if a value in the original file (before it gets pre-parsed) contains single or double quotes? |
| testQuoting: | ||
| complex1: 'this is "very" complex quoting' | ||
| complex2: "this is also 'very' complex quoting" | ||
| middle: this string is "quoted" in the middle |
There was a problem hiding this comment.
How about the above but also just a single quote? Complex2 would pass without being modified because it's a quoted value in it's entirety, and middle would pass because the value would be wrapped in single quotes, but I'm wondering about middeSingle: this string has some single quote's, and maybe a 'air quote', anything to make your life diff'cult
|
@mjauvin what's the status on this? |
@LukeTowers since we reverted @bennothommo 's work on this, it's currently irrelevant as far as I remember. |
|
@bennothommo what's the status of this? |
|
@LukeTowers you'd have to check with @mjauvin of what the purpose of this PR was? I'm not sure if it's needed, but I also can't recall the reason we had to roll back my processor originally - there was some sort of issue with it, I imagine? |
|
@LukeTowers it was needed at the time (see the tests that were added). Not sure if it's still relevant. |
No description provided.