Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for realbogus in WINTER. The model itself is defined in a new external package (https://github.com/winter-telescope/winterrb), which is added as a dependency. The model weights are downloaded from the github directly, so can be easily bumped by pointing to a new URL.
This is scalable to any other pytorch model. Fix #877.
The PR also adds cuts to what we sent to IPAC, in particular rb > 0.5 or null. It also adds an sgcut on the drp side. However, these changes only impact what is sent. There is no change to the way candidates are initially generated. After testing RB in deployment for a while, we can consider a loose rb cut before entering things in the database.