Docker Integration #1069
Draft
Docker Integration #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13092699177Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Docker option. It is likely to be the main way to run
miraron M1 macs, alongside an environment with manually installed astromatic packages.It's a big change, but it's become unavoidable I think. The problem is that the old osx-64 conda is being abandoned by packages we use e.g pytorch (e.g #1028), and the new osx-arm64 conda environment does not have source-extractor/scamp etc (#352). We are unable to move to numpy V2 with our pinned pytorch version (#1057), and since numpy is very widely used, we are likely going to be unable to use new versions of most packages in the near future.
This should also provide a very fast/simplified method for installing
mirar.As a bonus, this PR adds support for specifying the directory containing astrometry.net index files using environment variables. That was required for Docker, but is just generally very handy and simplifies installation.
Fix #790