Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Optionally close images to save RAM #197

Closed
robertdstein opened this issue Nov 17, 2022 · 0 comments · Fixed by #231
Closed

[FEATURE] Optionally close images to save RAM #197

robertdstein opened this issue Nov 17, 2022 · 0 comments · Fixed by #231
Labels
enhancement New feature or request nearfuture not required now, but will be important soon wishlist Non-urgent better-ification

Comments

@robertdstein
Copy link
Member

Is your feature request related to a problem? Please describe.
I'm always frustrated when I run out of ram. Sometimes this is the fault of the code, because it opens all the images and that can be a large cumulative size for N00 images in a night.

Describe the solution you'd like
I think we should at least have the option of writing images to a temp file rather than keeping it in RAM. You could have a custom get_data() method in the newly-designed Image object class (#196 is a prerequisite to this) to manage this.

Describe alternatives you've considered
Always opening/closing images, but that would be slower for some N images.
@robertdstein robertdstein added enhancement New feature or request wishlist Non-urgent better-ification nearfuture not required now, but will be important soon labels Nov 17, 2022
@robertdstein robertdstein linked a pull request Dec 7, 2022 that will close this issue
Close #197, use cache to massively reduce RAM #231
Merged
robertdstein added a commit that referenced this issue Dec 13, 2022
@robertdstein
Close #197, use cache to massively reduce RAM (#231)
c985f0e 
* Protect Image.data

* Only skip docs

* Remove redindant test

* Clean paths.py

* Document cache mode

* Add env.example

* Maintain option for both cache/non-cache

* Maintain option for both cache/non-cache

* Update poetry lock

* Set an escalating floor for pylint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nearfuture not required now, but will be important soon wishlist Non-urgent better-ification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #197, use cache to massively reduce RAM winter-telescope/mirar
1 participant
@robertdstein