Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use external camera #419
base: main
Are you sure you want to change the base?
use external camera #419
Changes from all commits
a1861e7
458a952
1514ccc
17be599
954733d
4ac4d9c
8c6421e
60dab09
319a5ba
774a57a
65ae816
3547b79
dffa8e3
68ac2d4
9380d0d
7fa117c
e9fc937
df7bcba
2a3101f
454adb4
d2566ff
e1b2689
54fa508
e539a31
2d21d4a
a50f661
7a0314c
b0e046d
5f3365a
b0e7bd9
6ea97a9
7688b39
5be2bac
a5030d6
10c543d
36c49bf
5056eb9
2593e7b
4f5a716
f90fdc6
fd8f417
f90153a
4bc7d3b
cf268c4
8d842a9
c494225
3d7311d
93d884c
f65f3a9
65a14c5
99eb129
c0301a8
fae48cb
33ecfad
e6cff54
c1e31ab
0b2bd7a
3595251
21ebf09
132c33b
ca4a607
924c36a
b417761
ea177a1
db6718e
50f0094
8817478
c436282
0c92940
1d9dda1
70fd167
e4993db
149d153
a1fff9f
b5671ab
6b40084
94e7ebc
039ae74
233a6b9
69f2fea
f6067ff
cbb85bc
6fee407
e738e67
40a54b4
ae0cf5f
4e95328
69ab3a4
f9bfe92
b39b3f0
0e99a59
19a1624
ae7a8ca
20f6256
1a9812f
afb6219
e5e91a7
512b32d
95975f3
3cef6b7
719426e
80dd516
b7cfd37
0090eb6
c7abbb4
d67f9e6
7fb3bfc
b6e27c7
9140e5c
2ec1877
7b0ba13
fbf9c6d
3e709bc
077794b
73c5157
c6e3996
bea15e1
99a8c56
6d6d8fb
3507722
d0d8231
5e3f31b
7da9d91
3f7f038
7b830ac
b698f3a
235fb20
d9ebb82
b5029a0
2f90006
92278ba
0d78be7
e927bdc
4c5a8c1
71b50f9
e42bab4
f47199b
cee2348
38cae27
f7a6c88
b458261
085467e
1969e2e
8142955
75095a4
bbf7282
3625403
62543d7
8648749
fbfdcf5
e301cde
533f547
a4add73
e8f8d21
e0eda9c
7c98630
2db69ea
acd5961
611c85d
b45bb2d
9610d11
b0654fb
2935fef
c1f1618
86cee92
a42d507
6494b09
a27616b
95c3873
3c42f4a
5fd264c
7d4a270
bd2f85f
5a900e7
1986b27
bc2b2bd
cc27f5a
fa8fdac
a9013b3
37a22bd
2322737
bad384b
9459239
da39153
420f678
e21d88f
253592c
443b5b6
7887539
384c7b0
3c7d15a
0ce5e0f
40f2c00
69b6a17
4d7200c
5ed85de
1d2724c
aba1218
1672df3
554d813
02318b2
62d10aa
8e890d7
d85b4b2
40eca1b
2b0dd62
2c7809b
756ad78
e2ef82f
90e5057
16b32a7
48602a2
c93264b
90c60c7
0bc6215
c875fee
94286d6
729dc6e
1d93b7f
275daeb
778dc4a
c5b9e83
b39c60e
2a365f3
eb7c0f4
75eb030
cd1881a
f32b719
9720f2a
6bf31e5
88768fb
70bbbd8
1bdbf05
31e830b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply
speedModifier
consistently to movementCurrently,
speedModifier
is applied only to the horizontal movement (line 103) but not to the forward/backward movement (line 102). This could lead to inconsistent movement speeds when moving diagonally, as holding the left control key will slow horizontal movement but not forward movement.Consider applying
speedModifier
to both movement axes to ensure consistent speed adjustments.Apply this diff to adjust the movement calculation:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent potential null reference exceptions
In the
Update
method, you check ifNoClipKeyboard
is enabled or ifCharacterController
is disabled. However, ifCharacterController
isnull
, accessingCharacterController.enabled
could throw a null reference exception.Consider adding a null check for
CharacterController
before accessing itsenabled
property:📝 Committable suggestion