[fix] Get tailFile function working on latest/all node versions
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. Lets review at the next WG meeting on Tuesday. |
indexzero
added a commit
that referenced
this pull request
Jun 30, 2015
[fix] Get `tailFile` function working on latest/all node versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When node changed the fs.ReadStream to use the new Streams API, the tricky tailFile function I originally wrote broke because resume/destroy methods worked differently (and I was sort of hooking into them and abusing them). I rewrote tailFile from scratch for use in other projects. It just uses the lowest level
fsfunctions now, without any shortcuts like before. This should work in all node versions.The tests seem to be passing.