Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (dependency of async) #1666

Closed
wants to merge 5 commits into from
Closed

Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (dependency of async) #1666

wants to merge 5 commits into from

Conversation

diegoh
Copy link

@diegoh diegoh commented Jul 3, 2019 •
edited
Loading

Snyk reported a vulnerability with lodash, which is a dependency of this package.
https://snyk.io/vuln/SNYK-JS-LODASH-450202

Updated to async@3.1.0 as it removes the dependency on lodash.
Updated other dependencies reported by npm audit.

@diegoh diegoh changed the title WIP: fix: prototype pollution in _.defaultsDeep WIP: Fix vulnerable dependencies including prototype pollution in _.defaultsDeep found in lodash Jul 8, 2019
@diegoh diegoh changed the title WIP: Fix vulnerable dependencies including prototype pollution in _.defaultsDeep found in lodash Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash Jul 8, 2019
@diegoh diegoh marked this pull request as ready for review July 8, 2019 20:31
@diegoh diegoh changed the title Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (async) Jul 18, 2019
@diegoh diegoh changed the title Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (async) Update vulnerable dependencies and fix prototype pollution in _.defaultsDeep found in lodash (dependency of async) Jul 18, 2019
@thebillg
Copy link

Can we please get this one merged? @indexzero

@DABH
Copy link
Contributor

DABH commented Aug 15, 2019

Closing in favor of #1686

@DABH DABH closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegoh @thebillg @DABH