Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CliFormat use cli levels (not npm levels). #135

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Conversation

MatrixFrog
Copy link
Contributor

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a breaking change? Can we union these two sets of levels so that there’s no chance of this being a break and change, and then fully do the switchover in the next major version? Or, is the proposed set of levels a strict superset of the current set of levels?

@MatrixFrog
Copy link
Contributor Author

Hm, good question. The levels are https://github.com/winstonjs/triple-beam/blob/master/config/cli.js and https://github.com/winstonjs/triple-beam/blob/master/config/npm.js

The only one that's in npm but not in cli is http. But also, verbose and debug are in the opposite order between the two.

I'm not really sure if it could be a breaking change but I guess it's possible.

@MatrixFrog
Copy link
Contributor Author

I guess my intuition is that it's unlikely to be a breaking change unless someone is expecting a very specific format, down to the exact number of spaces, in their logs. But obviously it's your call. Happy to change it, or I checked the box so you can change it too.

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and try this. Thank you!

@DABH DABH merged commit 6c677ed into winstonjs:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When calling logger.data(), an 'undefined' is mysteriously added to the log output
2 participants