Skip to content

Commit

Permalink
refactor: remove any in index.d.ts (#325)
Browse files Browse the repository at this point in the history 
* remove any in index.d.ts

* Update index.d.ts
  • Loading branch information
@intellectus-rojiwon
intellectus-rojiwon authored Oct 14, 2024
1 parent ae6e926 commit 55f3d8c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions index.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ import {LEVEL, MESSAGE, SPLAT} from 'triple-beam'

export interface TransformableInfo {
level: string;
message: any;
message: unknown;
[LEVEL]?: string;
[MESSAGE]?: any;
[SPLAT]?: any;
[key: string | symbol]: any;
[MESSAGE]?: unknown;
[SPLAT]?: unknown;
[key: string | symbol]: unknown;
}

export type TransformFunction = (info: TransformableInfo, opts?: any) => TransformableInfo | boolean;
export type TransformFunction = (info: TransformableInfo, opts?: unknown) => TransformableInfo | boolean;
export type Colors = { [key: string]: string | string[] }; // tslint:disable-line interface-over-type-literal
export type FormatWrap = (opts?: any) => Format;
export type FormatWrap = (opts?: unknown) => Format;

export class Format {
constructor(opts?: object);
Expand Down Expand Up @@ -82,7 +82,7 @@ export interface JsonOptions {
/**
* A function that influences how the `info` is stringified.
*/
replacer?: (this: any, key: string, value: any) => any;
replacer?: (this: unknown, key: string, value: unknown) => unknown;
/**
* The number of white space used to format the json.
*/
Expand Down

3 comments on commit 55f3d8c

@apanjwani0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I think this is a breaking change.
I used to implement it like this

logger.add(
        new winston.transports.Console({
          level: 'debug',
          format: winston.format.combine(
            winston.format.colorize({ all: false }),
            ConsoleLogFormatDev,
          ),
        }),
      );

const ConsoleLogFormatDev = winston.format.printf((info) => {
  let log = `${info.level}: ${info.message} `;

  if (info.metadata.responseTime) {
    log = `${log}: ${info.metadata.responseTime} ms `;
  }
  if (info.metadata.stack) {
    log = `${log}: ${info.metadata.stack} `;
  }
  if (info.metadata.durationMs) {
    log = `${log} ${info.metadata.durationMs} ms`;
  }

  if (info.metadata.printConsole) {
    log = `${log}: ${JSON.stringify(info.metadata, null, '\t')}`;
  }
  return log;
});

Now getting this error: Image

@Cooldude2606
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, also broke my build.

Code:
https://github.com/clusterio/clusterio/blob/ace8356f6807bf853075f501166215c834544b03/packages/lib/src/logging_utils.ts#L145-L183

Output: Image

@GianniCodato-PixartPrinting
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue also on my side

Please sign in to comment.