Revert "fix: fix worker restart on otel setting set from undefined to null" #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… null (#…" This reverts commit 940fb03.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5374696 in 10 seconds
More details
- Looked at
14lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_x34bkknC9Z1DdLgL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5183
Important
Reverts #5183 by deleting SQL migration files for 'otel' global settings.
20250131115248_otel_global_settings.up.sqland20250131115248_otel_global_settings.down.sqlwhich added and removed 'otel' setting inglobal_settingstable.This description was created by
for 5374696. It will automatically update as commits are pushed.