#477 | Fixing category selection after deletion #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyerr
approved these changes
Apr 12, 2022
Clstroud
requested changes
Apr 12, 2022
Comment on lines
197
to
200
| if let category = Category.fetchObject(in: NSPersistentContainer.shared.viewContext, matching: previous.objectID), | ||
| category.isUserRemoved { | ||
| return previous.indexPath | ||
| } |
There was a problem hiding this comment.
I've been staring at this for a hot minute and I'm wondering if I'm misunderstanding something. previous.indexPath is no longer relevant to the new snapshot and could even be (I suppose?) out of bounds for said new snapshot, right?
What happens if you return nil instead?
|
Test verified on: |
Clstroud
approved these changes
Apr 13, 2022
|
Test verified on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #477
Description of Work
Fixing a bug where after deleting the first category and navigating back to the home screen, the second category was selected inside of the first.