#490 | Fixing Audio in Silent Mode 🔈 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playback to allow audio in silent mode|
Tested and verified to be working as expected. Regardless of the state of the 'silent mode' switch on an iPhone device, the app will speak aloud selections. I did find an issue whereby the volume level of the output is very low when listening mode is engaged. It corrects itself when you turn off listening mode. But this behavior is reproducible on develop. So I will write up a separate bug for it. |
moyerr
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #490
Description of Work
The audio was not playing in silent mode when tapping on phrases or reading out text. To fix this, the
AudioEngineCategoryis initialized as a property inSpeechRecognitionControllerso that the audio session category is initially set toplaybackto allow audio in silent mode. Also fixed issue where audio session wasn't switching back toplaybackafter turning off listening mode.