Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Category: Adding a Phrase - Alert When Duplicating Existing Phrase #484

Closed
Ly-Kyli opened this issue Mar 22, 2022 · 2 comments · Fixed by #530
Closed

Custom Category: Adding a Phrase - Alert When Duplicating Existing Phrase #484

Ly-Kyli opened this issue Mar 22, 2022 · 2 comments · Fixed by #530

Comments

@Ly-Kyli
Copy link

Ly-Kyli commented Mar 22, 2022

Story: As a user, I want to be notified when I am adding a custom phrase that matches a pre-existing phrase. This includes any of my other custom phrase.

Acceptance Criteria:

  1. If a user adds a phrase that's already been added before, we should present an alert notifying them: "This phrase already exists. Continue to add the phrase?" with the option of "Continue" and "Cancel".

Design:
Discussed in meeting but need to follow up with Steve

@Ly-Kyli Ly-Kyli changed the title Create/Edit Custom Category: Adding a Phrase - Prevent Duplicating Existing Phrase Custom Category: Adding a Phrase - Alert When Duplicating Existing Phrase Mar 23, 2022
@jsmorgan42 jsmorgan42 self-assigned this Mar 31, 2022
@rhsalas3 rhsalas3 linked a pull request Apr 4, 2022 that will close this issue
@rhsalas3
Copy link
Contributor

rhsalas3 commented Apr 4, 2022

@SashankPatel

@CananArikan and I tested this issue's implementation on @jsmorgan42 's PR #530

The alert is functional and matches designs, but some of the flows in which we expect to get the alert, or not, have some issues. We are going to mark this issue as "Test requesting changes" and I have left a comment on the PR conversation thread to specify what the issues are that we're seeing.

This issue is related to #461

@rhsalas3
Copy link
Contributor

rhsalas3 commented Apr 6, 2022

This feature has been tested and verified to be working as expected.

The alert appears and behaves as expected and matches designs.

jsmorgan42 added a commit that referenced this issue Apr 6, 2022
…gory-alert

#461 & #484 | Existing Phrase & Category Refactor
@rhsalas3 rhsalas3 mentioned this issue Apr 19, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants