Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Layout in the Phrases view based on designs #476

Closed
SashankPatel opened this issue Mar 17, 2022 · 1 comment · Fixed by #496
Closed

Update Layout in the Phrases view based on designs #476

SashankPatel opened this issue Mar 17, 2022 · 1 comment · Fixed by #496
Assignees
@jsmorgan42
Labels
Custom Categories Test verified v1.4

Comments

@SashankPatel
Copy link
Contributor

SashankPatel commented Mar 17, 2022 •
edited by jsmorgan42
Loading

Acceptance Criteria:
No Functional changes.

  • As a user I shall be able to delete phrases.
  • As a user I shall be able to edit phrases
  • As a user I shall be able to add new phrases.
  • As a user I shall be able to scroll through multiple pages of phrases

The layout on the Edit Phrase view has updated. The delete confirmation button should be red. This ticket is to make updates to the existing UI to implemented the design updates.

Design:
iPad Landscape: https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=969%3A1629
iPad Portrait: https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=3398%3A19036
iPhone: https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=3356%3A17664
Clstroud added a commit that referenced this issue Mar 18, 2022
@Clstroud
#476 Restructure VocableListCell
e09caf3
Clstroud added a commit that referenced this issue Mar 18, 2022
@Clstroud
#476 Use index paths for phrase manipulation in EditPhrasesVC
f7fa661
Clstroud added a commit that referenced this issue Mar 18, 2022
@Clstroud
#476 VocableListCellContent trailingAccessory enhancements
4ab8061
jsmorgan42 pushed a commit that referenced this issue Mar 18, 2022
#476 Adding inter-row & inter-column spacing
3092381
jsmorgan42 pushed a commit that referenced this issue Mar 18, 2022
#476 Fixing crash when deleting first cell
f9d8994
Clstroud added a commit that referenced this issue Mar 23, 2022
@Clstroud
#476 WIP continued refinement on VocableListCell
6766075
jsmorgan42 pushed a commit that referenced this issue Mar 23, 2022
#476 Preventing view re-creation
6a0c79e
@jsmorgan42 jsmorgan42 mentioned this issue Mar 23, 2022
Merged
@rhsalas3
Copy link
Contributor

rhsalas3 commented Mar 25, 2022 •
edited
Loading

Tested and confirmed on Jesse's PR branch for this issue; PR #496

Layout matches designs and there are no regressions on functionality. I confirmed this for preset and custom categories/phrases.

jsmorgan42 added a commit that referenced this issue Mar 28, 2022
@jsmorgan42
Merge pull request #496 from willowtreeapps/feature/476-custom-catego…
202c622 
…ry-refactor

#476 | Custom Category Refactor
jsmorgan42 pushed a commit that referenced this issue Mar 30, 2022
#476 | Implementing EditPhraseNameController
0413fcf
@rhsalas3 rhsalas3 mentioned this issue Apr 19, 2022
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsmorgan42 jsmorgan42

Labels
Custom Categories Test verified v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#476 | Custom Category Refactor willowtreeapps/vocable-ios
3 participants
@rhsalas3 @jsmorgan42 @SashankPatel