This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
feat: add a logger based on plenary.log #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a demo of what it looks like in action:
|
|
Cool!! This is something I had in mind. One thing that kept me putting this of is the log-to-storage part. I glanced through the code so I think I have the answer, but is there any log rotation/pruning in place? Bit worried that these log files are unbounded in size and will just keep growing forever, which is not very cash money. The amount of logging that is in place today is no cause for concern though, but I was planning on adding a bunch more (like performance metrics and whatnot). |
These don't conform to the logger signature, will fix later.
williamboman
approved these changes
Sep 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a logger based on Plenary's log implementation.
I basically hijacked the notify function, so it's trivial to swap out the logger for a more sophisticated one, should you wish so.
Note: It's up to you to decide on how to set the default log level.