This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
make version usefull for reinstalling #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i dont really find the check that is responsible for that KeyError: key{linenumber} not found |
|
seems legit, will test it locally and investigate what broke the build |
|
the issue was caused by a broken puppetlint configuration. I fixed it on the master branch (5dff357). If you rebase master onto your branch and push this again, the build should be green (all tests passing on my machine) |
Ma27
approved these changes
Jan 20, 2017
|
merged locally, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Right now the version parameter does only work at the first install. After that the "creates" param of exec disables any update/downgrade. I added a unless with test and grep to install the correct version.
We could use the self-update of composer to update to a specific version, but i dont know how that works for downgrades and it could possibly make you packages unable to work.