Skip to content

Commit

Permalink
Revert "[tests] install wikitextparser instead of mwpfh for Python 3.13"
Browse files Browse the repository at this point in the history
Seems this issue is solved by Python 3.13rc2.
This reverts commit a57f71a.

Bug: T372162
Change-Id: Ia0fd6f58b5b5e00388f3c31c6d84dece94ebba9e
  • Loading branch information
xqt committed Sep 20, 2024
1 parent e81c77a commit 9d28827
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/doctest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
pip --version
pip install coverage
pip install "importlib_metadata ; python_version < '3.8'"
pip install "mwparserfromhell ; python_version != '3.13'"
pip install mwparserfromhell
pip install packaging
pip install "PyMySQL >= 1.0.0"
pip install pytest
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/login_tests-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ jobs:
pip --version
pip install coverage
pip install "importlib_metadata ; python_version < '3.8'"
pip install "mwparserfromhell ; python_version != '3.13'"
pip install "wikitextparser ; python_version == '3.13'"
pip install mwparserfromhell
pip install packaging
pip install requests
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/oauth_tests-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ jobs:
pip --version
pip install coverage
pip install "importlib_metadata ; python_version < '3.8'"
pip install "mwparserfromhell ; python_version != '3.13'"
pip install "wikitextparser ; python_version == '3.13'"
pip install mwparserfromhell
pip install mwoauth
pip install packaging
pip install requests
Expand Down
3 changes: 1 addition & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
# $ awk -F '[#>=]' '{print $1}' requirements.txt | xargs apt-cache search

# mandatory dependencies, others are optional
# mwparserfromhell fails with Python 3.13 (T372162)
importlib_metadata ; python_version < '3.8'
mwparserfromhell>=0.5.2; python_version != '3.13'
mwparserfromhell>=0.5.2
packaging
requests>=2.21.0

Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@
# packages which are mandatory
dependencies = [
'importlib_metadata ; python_version < "3.8"',
'mwparserfromhell>=0.5.2; python_version != "3.13"',
'wikitextparser; python_version == "3.13"',
'mwparserfromhell>=0.5.2',
'packaging',
'requests>=2.21.0',
]
Expand Down

0 comments on commit 9d28827

Please sign in to comment.