Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies packages #214

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Update devDependencies packages #214

merged 2 commits into from
Jun 2, 2020

Conversation

amire80
Copy link
Contributor

@amire80 amire80 commented May 26, 2020

eslint-config-wikimedia: 0.14.1 -> 0.15.3
eslint-plugin-qunit: 4.0.0 -> 4.2.0
grunt-eslint: 22.0.0 -> 23.0.0
jquery: 3.4.0 -> 3.5.1

@Nikerabbit
Copy link
Member

Failure might be due to requiring eslint7, which no longer supports node 0.10.x. Some of the packages pull in eslint 7.1, as can be seen in package-lock.json. I think it's grunt-eslint and maybe others.

@amire80
Copy link
Contributor Author

amire80 commented May 27, 2020

Mmmm... And do we need to support this version of node?

@Nikerabbit
Copy link
Member

This isn't a node library, so no. I think it's only used for linting/testing. Latest version that Travis needs is sufficient.

@amire80
Copy link
Contributor Author

amire80 commented May 27, 2020

OK, and do you know how to fix it?

@Nikerabbit
Copy link
Member

@amire80
Copy link
Contributor Author

amire80 commented May 28, 2020

OK, done in #215

@amire80
Copy link
Contributor Author

amire80 commented May 29, 2020

#215 appears to have fixed this issue, but created some others. I'm working on it.

amire80 added 2 commits May 29, 2020 08:15
eslint-config-wikimedia: 0.14.1 -> 0.15.3
eslint-plugin-qunit: 4.0.0 -> 4.2.0
grunt-eslint: 22.0.0 -> 23.0.0
jquery: 3.4.0 -> 3.5.1
@Nikerabbit Nikerabbit merged commit d0931f9 into wikimedia:master Jun 2, 2020
@amire80 amire80 deleted the npm branch June 10, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants