Merge pull request #165 from wikimedia/lint-fixes-0.6.0

Update eslint-config-wikimedia and fix issues

src/jquery.i18n.js

@@ -46,6 +46,8 @@
 			String.locale = i18n.locale;
 
 			// Override String.localeString method
+			// FIXME: This is a mistake. We should not modify String.prototype
+			/* eslint-disable no-extend-native */
 			String.prototype.toLocaleString = function () {
 				var localeParts, localePartIndex, value, locale, fallbackIndex,
 					tryingLocale, message;
@@ -75,7 +77,8 @@
 						break;
 					}
 
-					locale = ( $.i18n.fallbacks[ i18n.locale ] && $.i18n.fallbacks[ i18n.locale ][ fallbackIndex ] ) ||
+					locale = ( $.i18n.fallbacks[ i18n.locale ] &&
+						$.i18n.fallbacks[ i18n.locale ][ fallbackIndex ] ) ||
 						i18n.options.fallbackLocale;
 					$.i18n.log( 'Trying fallback locale for ' + i18n.locale + ': ' + locale + ' (' + value + ')' );
 
@@ -146,7 +149,8 @@
 				// source extension should be json, but can have query params after that.
 				source.split( '?' )[ 0 ].split( '.' ).pop() !== 'json'
 			) {
-				// Load specified locale then check for fallbacks when directory is specified in load()
+				// Load specified locale then check for fallbacks when directory is
+				// specified in load()
 				sourceMap[ locale ] = source + '/' + locale + '.json';
 				fallbackLocales = ( $.i18n.fallbacks[ locale ] || [] )
 					.concat( this.options.fallbackLocale );

src/jquery.i18n.parser.js

@@ -152,9 +152,9 @@
 			anyCharacter = makeRegexParser( /^./ );
 			dollar = makeStringParser( '$' );
 			digits = makeRegexParser( /^\d+/ );
-			regularLiteral = makeRegexParser( /^[^{}\[\]$\\]/ );
-			regularLiteralWithoutBar = makeRegexParser( /^[^{}\[\]$\\|]/ );
-			regularLiteralWithoutSpace = makeRegexParser( /^[^{}\[\]$\s]/ );
+			regularLiteral = makeRegexParser( /^[^{}[\]$\\]/ );
+			regularLiteralWithoutBar = makeRegexParser( /^[^{}[\]$\\|]/ );
+			regularLiteralWithoutSpace = makeRegexParser( /^[^{}[\]$\s]/ );
 
 			// There is a general pattern:
 			// parse a thing;
@@ -209,7 +209,7 @@
 			templateName = transform(
 				// see $wgLegalTitleChars
 				// not allowing : due to the need to catch "PLURAL:$1"
-				makeRegexParser( /^[ !"$&'()*,.\/0-9;=?@A-Z\^_`a-z~\x80-\xFF+\-]+/ ),
+				makeRegexParser( /^[ !"$&'()*,./0-9;=?@A-Z^_`a-z~\x80-\xFF+-]+/ ),
 
 				function ( result ) {
 					return result.toString();
@@ -294,7 +294,8 @@
 			/*
 			 * For success, the pos must have gotten to the end of the input
 			 * and returned a non-null.
-			 * n.b. This is part of language infrastructure, so we do not throw an internationalizable message.
+			 * n.b. This is part of language infrastructure, so we do not throw an
+			 * internationalizable message.
 			 */
 			if ( result === null || pos !== message.length ) {
 				throw new Error( 'Parse error at position ' + pos.toString() + ' in input: ' + message );

src/languages/he.js

@@ -9,17 +9,17 @@
 			switch ( form ) {
 				case 'prefixed':
 				case 'תחילית': // the same word in Hebrew
-				// Duplicate prefixed "Waw", but only if it's not already double
+					// Duplicate prefixed "Waw", but only if it's not already double
 					if ( word.slice( 0, 1 ) === 'ו' && word.slice( 0, 2 ) !== 'וו' ) {
 						word = 'ו' + word;
 					}
 
-				// Remove the "He" if prefixed
+					// Remove the "He" if prefixed
 					if ( word.slice( 0, 1 ) === 'ה' ) {
 						word = word.slice( 1 );
 					}
 
-				// Add a hyphen (maqaf) before numbers and non-Hebrew letters
+					// Add a hyphen (maqaf) before numbers and non-Hebrew letters
 					if ( word.slice( 0, 1 ) < 'א' || word.slice( 0, 1 ) > 'ת' ) {
 						word = '־' + word;
 					}

src/languages/os.js

@@ -34,8 +34,7 @@
 				// vowel 'U' in cyrillic Ossetic.
 				// Examples: {{grammar:genitive|аунеу}} = аунеуы,
 				// {{grammar:genitive|лæппу}} = лæппуйы.
-				if ( !word.slice( -2, -1 )
-						.match( /[аæеёиоыэюя]$/i ) ) {
+				if ( !word.slice( -2, -1 ).match( /[аæеёиоыэюя]$/i ) ) {
 					jot = 'й';
 				}
 			} else if ( !word.match( /[бвгджзйклмнопрстфхцчшщьъ]$/i ) ) {