This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Wib 859/Filter processed emails #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #97 +/- ##
===========================================
+ Coverage 92.3% 92.42% +0.11%
===========================================
Files 9 9
Lines 130 132 +2
===========================================
+ Hits 120 122 +2
Misses 10 10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #97 +/- ##
===========================================
+ Coverage 92.3% 92.42% +0.11%
===========================================
Files 9 9
Lines 130 132 +2
===========================================
+ Hits 120 122 +2
Misses 10 10
Continue to review full report at Codecov.
|
nicoayala
approved these changes
Jul 23, 2019
Agus
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Send order uuid instead of dxid to identify validated batch, and nonce as another param.
Are there points in the code the reviewer needs to double check?
No.
Why was this Pull Request needed?
This way the validator knows how to group different batches with different nonces.
Does this Pull Request meet the acceptance criteria?