Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring cache bug by setting dummy archive location #14

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

itchyny
Copy link

@itchyny itchyny commented Feb 14, 2024

In the current implementation the cache can never be restored. I was investigating the cache restoration behavior. Previously I sent #13 and the number of objects prevents me to restore the cache. However, the action was broken by #10, specifically by the commit 20b1ecb. Previously if cacheKey exists the cache was restored correctly, but currently archiveLocation is required.

-  if (!cacheEntry?.archiveLocation && !cacheEntry?.cacheKey) {
-     // Cache not found
-     return undefined
-   }
+  if (!cacheEntry?.archiveLocation) {
+     // Cache not found
+     return undefined
+  }

20b1ecb#diff-34e72845d1658a8a9b9fdfe6b5b9261952e7f0496a0a3fcec87dae722718a64aL99

@whywaita whywaita merged commit 8fcb3fa into whywaita:main Feb 14, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants