add p2p-webrtc-direct pattern #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
requested changes
Feb 27, 2019
There was a problem hiding this comment.
Minor comments. Overall LGTM, although I'm worried about turning mafmt into a *-import module in the long run.
To avoid stalling, I'll commit the changes myself on your branch.
EDIT: I can't because this repo is under whyrusleeping's account rather than in the multiformats org. I'll clone it there, migrate downstream usages in our control, and port over this PR.
patterns.go
Outdated
| // Define a dns6 format multiaddr | ||
| var DNS6 = Base(madns.P_DNS6) | ||
|
|
||
| var _DNS = Or( |
There was a problem hiding this comment.
If this is copied from js-mafmt, the _ convention usually denotes unexported vars. In go you can lowercase this.
patterns.go
Outdated
|
|
||
| // Define a dns4 or dns6 format multiaddr | ||
| var DNS = Or( | ||
| And(_DNS, Base(ma.P_TCP)), |
There was a problem hiding this comment.
This one is wonky at origin: multiformats/js-mafmt#40
|
This was added in multiformats/go-multiaddr-fmt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the
p2p-webrtc-directpattern fromjs-mafmtin preparation of ago-libp2p-webrtc-directtransport. It depends on:I'll probably need some help with the dependency management.