Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pravetz 82 support #204

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Add Pravetz 82 support #204

merged 6 commits into from
Nov 26, 2023

Conversation

zayfod
Copy link
Contributor

@zayfod zayfod commented Nov 26, 2023

Overview

Pravetz 82 is a Bulgarian Apple ][ clone - https://en.wikipedia.org/wiki/Pravetz_82

As the excellent Apple ][js already supports different "system types", if it is appropriate, I would like to propose adding "Pravetz 82" to it.

I find quite amusing the idea that, Bulgaria cloned the Apple hardware ][ in the '80s and customized the ROMs and 40 years later it is possible to clone an Apple ][ emulator and run the same customized ROMs on it with no changes. :)

The main challenge was adapting the keyboard which does specific key remapping to allow replacing the lower-case latin letters with upper-case Cyrillic ones, changes the behavior of the Shift key and introduces a Caps Lock-like key for switching between languages. To allow that and to make the keyboard look similar to the original one, I introduced a "keyboard layout" concept.

I'd be happy to adapt the code further, if necessary.

image
image
image
image

The original:
image

@zayfod zayfod changed the title Add Pravetz 82 support. Add Pravetz 82 support Nov 26, 2023
Copy link
Owner

@whscullin whscullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, when I saw it in my notifications I thought it was a feature request, not a PR, so I thought, well, that's a good idea and I can look into it but I need track down ROMs and such, but no, that's all here. I love the keyboard color detail.

My Internet Archive search didn't turn up much in the way of software, if you have any images that I could put up that would be cool.

break;
}
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think that I probably should have used a table lookup for this before, but that's a future optimization.

@whscullin whscullin merged commit 9d536ae into whscullin:main Nov 26, 2023
@zayfod
Copy link
Contributor Author

zayfod commented Nov 26, 2023

Thanks for the prompt response!

I'd try to update the new application keyboard (js/components/util/keybaord.ts) also and maybe add Pravetz 8M and Pravetz 8M (Apple //e based) later.

Regarding software, I have a few Bulgarian disk images. Are you suggesting adding them to json/disks/?

@whscullin
Copy link
Owner

I tend to not add a lot of disks to the code repo, because it could easily become a slippery slope, but having a disk that allows for testing would be great. If there are other disks (I searched archive.org and didn't see any) I could add them to the software library on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants