Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the python version #31

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

timurcarstensen
Copy link
Collaborator

@timurcarstensen timurcarstensen commented Jun 25, 2024

This PR bumps the python version of the project

I propose that we move the library to python 3.11 (or even better 3.12):

  • Python 3.11 (and 3.12) introduced significant performance speedups over previous versions
  • PyTorch will soon stop supporting 3.8
  • It is easy to bump versions now, when there is still relatively little complexity

For this I have updated .github/workflows/unit-test.yml and setup.py

@timurcarstensen
Copy link
Collaborator Author

Okay final update @aaronkl: we decided to bump the project version to 3.9 and test for 3.9 to 3.11 (including). This is primarily due to this comment regarding the changes to type hinting introduced in 3.9

@aaronkl
Copy link
Collaborator

aaronkl commented Jul 1, 2024

@timurcarstensen thanks for pushing this! Looks good to me. Could you add a sentence to the README that we only support python 3.9 - python 3.11?

@timurcarstensen
Copy link
Collaborator Author

I updated the README.md @aaronkl, could we merge this today?

@timurcarstensen timurcarstensen merged commit ef240e4 into main Jul 2, 2024
5 checks passed
@timurcarstensen timurcarstensen deleted the test-python-311-and-312 branch July 2, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants