Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search results - evaluation and results processing #249
feat: search results - evaluation and results processing #249
Changes from 26 commits
f62a1d3
c09d528
99efc41
da068f7
168d35f
698a5ac
4eaef06
f046d7e
80660ae
a9fe3eb
cad9b2a
cf53449
9a85591
077fd7f
edb2071
47b986c
17fdb68
8f5fc56
d92ee72
4858167
f4dbd67
6cfed4b
805761a
c843b3c
52b5555
ffd56ae
37d03c5
06dfa1e
b875c27
3e3293a
77b6a00
70e328f
5efa912
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be part of SearchArgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine that you'll use binning outside of search (e.g. for pre-selection of networks to evaluate). But I can add it to SearchArgs