Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt+w when find widget visible #343

Merged
merged 1 commit into from
Jul 2, 2020
Merged

alt+w when find widget visible #343

merged 1 commit into from
Jul 2, 2020

Conversation

youyuanwu
Copy link
Contributor

alt+w binding when find widget visible changed from close the find widget only, to first close find widget then copy region.

@whitphx
Copy link
Owner

whitphx commented Jul 2, 2020

Thank you! LGTM 😄

BTW, I tested the original emacs' behavior of M-w and it looked more complicated... but perfect reimplementation of that behavior is not required by anyone now and of course we don't have to care of it.

@whitphx whitphx merged commit 9e18380 into whitphx:master Jul 2, 2020
@youyuanwu
Copy link
Contributor Author

I am also trying to figure out how to yank into findWidget. When in search (ctrl+s), ctrl+y should paste the kill ring to the search string. But this seems difficult to achieve in vscode keybinding.

@whitphx
Copy link
Owner

whitphx commented Jul 3, 2020

Yes, that seems impossible.
Ref: #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants