Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in LDLf test parser #76

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Bugfix in LDLf test parser #76

merged 2 commits into from
Sep 25, 2021

Conversation

cipollone
Copy link
Contributor

@cipollone cipollone commented Sep 25, 2021

Proposed changes

The parser object for the LDLf Test operator was read incorrectly. We were reading the token ? instead of the associated formula.
Waning: I debugged through logaut. I didn't execute this repo directly.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

+ The ? token was read from the parsing object, insted of the actual
  formula.
@cipollone cipollone changed the base branch from main to develop September 25, 2021 12:06
@marcofavorito
Copy link
Member

LGTM

@marcofavorito marcofavorito self-requested a review September 25, 2021 13:14
@marcofavorito marcofavorito merged commit a82a8a6 into develop Sep 25, 2021
This was referenced Sep 25, 2021
@marcofavorito marcofavorito deleted the test-fix branch June 2, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants