Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exclusion of certain projects from analysis #8

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Support exclusion of certain projects from analysis #8

merged 4 commits into from
Aug 8, 2024

Conversation

notxcain
Copy link

@notxcain notxcain commented Aug 5, 2024 •
edited
Loading

A project marked with partialSbtOpaqueProject setting will not contribute to invalidation of its dependent projects.

Given:
a <- b <- c
b <- d
c is marked as excluded

Then:

  1. If we change only c — c gets reported.
  2. If we change only d — a, b and d get reported
  3. If we change both c and d — a, b, c and d get reported

@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from 8d40c18 to 63dc294 Compare August 6, 2024 09:27
@notxcain notxcain requested review from danicheg and fido-node August 6, 2024 09:27
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from 63dc294 to 94f17ac Compare August 6, 2024 10:36
danicheg
danicheg approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from 356f146 to 7fcdb82 Compare August 6, 2024 14:00
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from 7fcdb82 to a9b843f Compare August 6, 2024 14:01
@notxcain
Copy link
Author

notxcain commented Aug 6, 2024

@danicheg I changed the name and behavior of the marker to support gRPC publishing from Atlas.

@notxcain notxcain requested a review from danicheg August 6, 2024 14:02
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from a9b843f to 7234eb4 Compare August 6, 2024 14:11
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch 2 times, most recently from 91fb032 to 523d175 Compare August 6, 2024 15:50
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch 3 times, most recently from 995ce6d to a8851fe Compare August 8, 2024 11:29
@notxcain notxcain force-pushed the hydra-2663-excluded-project branch from a8851fe to 115d57f Compare August 8, 2024 11:54
@notxcain notxcain merged commit 6c598b4 into master Aug 8, 2024
3 checks passed
@notxcain notxcain deleted the hydra-2663-excluded-project branch August 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fido-node fido-node Awaiting requested review from fido-node

@danicheg danicheg Awaiting requested review from danicheg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notxcain @danicheg