Display release country in matching releases

[the-confessor]

When I use whipper and there are multiple matching releases I like it to prompt me to confirm which one to use.

I usually find myself opening each musicbrainz URL just to look at the country for each of them, and that is how I choose.

I could avoid having to do this in most cases if the country was included in the ouput shown to me by whipper. Is it possible to add?

[ABCbum]

I think this one is somewhat similar to #167 right ?

Edit:

When I use whipper and there are multiple matching releases I like it to prompt me to confirm which one to use.

Also there is a --prompt option for this i guess here

[the-confessor]

Correct - my statement would have been better said "I am using the --prompt option so I can select the disc when there is more than one match."

#167 sounds like some enhancements related to the interactivity; I am happy with the current controls for interactivity, I would just like to see the country field presented to me when there are multiple matches.

e.g. this is what I saw for a CD I recently started to rip:

MusicBrainz disc id TW8p_wRBO1mXLKCI_H2HX873Qtk-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+10+187755+150+19597+34725+53272+72175+86125+102867+119312+138572+159210&tracks=10&id=TW8p_wRBO1mXLKCI_H2HX873Qtk-
Disc duration: 00:41:41.400, 10 audio tracks

Matching releases:

Artist  : Tilly and the Wall
Title   : Bottoms of Barrels
Duration: 00:41:52.000
URL     : https://musicbrainz.org/release/f4e74e9e-e58a-4e6e-ad94-d9db0de7e510
Release : f4e74e9e-e58a-4e6e-ad94-d9db0de7e510
Type    : Album
Cat no  : TL 09

Artist  : Tilly and the Wall
Title   : Bottoms of Barrels
Duration: 00:41:52.000
URL     : https://musicbrainz.org/release/6e515011-8e1e-3042-994d-9fdf50923fc1
Release : 6e515011-8e1e-3042-994d-9fdf50923fc1
Type    : Album

Please select a release [f4e74e9e-e58a-4e6e-ad94-d9db0de7e510]: 

This is what I would like to see:

MusicBrainz disc id TW8p_wRBO1mXLKCI_H2HX873Qtk-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+10+187755+150+19597+34725+53272+72175+86125+102867+119312+138572+159210&tracks=10&id=TW8p_wRBO1mXLKCI_H2HX873Qtk-
Disc duration: 00:41:41.400, 10 audio tracks

Matching releases:

Artist  : Tilly and the Wall
Title   : Bottoms of Barrels
Duration: 00:41:52.000
URL     : https://musicbrainz.org/release/f4e74e9e-e58a-4e6e-ad94-d9db0de7e510
Release : f4e74e9e-e58a-4e6e-ad94-d9db0de7e510
Type    : Album
Country : US
Cat no  : TL 09

Artist  : Tilly and the Wall
Title   : Bottoms of Barrels
Duration: 00:41:52.000
URL     : https://musicbrainz.org/release/6e515011-8e1e-3042-994d-9fdf50923fc1
Release : 6e515011-8e1e-3042-994d-9fdf50923fc1
Type    : Album
Country : Australia

Please select a release [f4e74e9e-e58a-4e6e-ad94-d9db0de7e510]: 

[ABCbum]

Ahh i get what you mean now. If that's the case how about using the --country flag (i guess you did so let me check if the code is doing what you are suggesting). ( ╹▽╹ )

Edit: I checked and it seems to work fine (here).

[the-confessor]

It's slightly different. The --country flag will filter that matches by country. I would like to show matches from all countries, but include the country information in the whipper output.

Use of the --country flag would require me to think about it before I put the CD in. Including country information in the output would mean I don't need to think about it unless there happens to be multiple matches.

[ABCbum]

Yeah you are right. Now it depends on what others and maintainers think about this feature (I think it should be fine). What do you guys think, @JoeLametta , @Freso , @MerlijnWajer ?

[JoeLametta]

I think this is a worthwhile improvement.

[JoeLametta]

@the-confessor Hi, i've added the feature you've requested in commit 85ccd29 (branch feature/issue-451-display-country). I haven't tested it so, if you can, please try it and let me know if it works as expected.

Cheers,
Joe

[JoeLametta]

@the-confessor My bad: I made a mistake. The correct commit to test is 6fab8e1.

EDIT: commit identifier updated.

[JoeLametta]

Related to #380.

[the-confessor]

I applied as a patch and it seems to do what I was expecting.

Incidentally, the first two CDs I tested with revealed a release can have multiple countries. Examples follow. Ideally in such cases it would list all the countries.

https://musicbrainz.org/release/aef7bf54-2081-4151-96e8-07b612704878
https://musicbrainz.org/release/4c55906c-349b-362d-922e-956762912b42

[JoeLametta]

I applied as a patch and it seems to do what I was expecting.

Good.

Incidentally, the first two CDs I tested with revealed a release can have multiple countries.

@the-confessor I've just pushed a new commit (af74f31) which should make whipper report all available countries (if available). I haven't tested it so, if you can, please try it and let me know if it works as expected.

Cheers,
Joe

[the-confessor]

I applied 6fab8e1 + af74f31 as a patch and confirm it works, it shows me all countries.