Improve error handling.

whilo · Apr 13, 2024 · eb15692 · eb15692
1 parent 5ddf9d8
commit eb15692
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/ie/simm/runtimes/telegram.clj b/src/ie/simm/runtimes/telegram.clj
@@ -111,7 +111,10 @@
                     (put? S next-in (assoc m
                                            :type :ie.simm.languages.chat/send-text-reply
                                            :response (try (t/send-text (:telegram-bot-token config) chat-id msg)
-                                                          (catch Exception e
+                                           ;; TODO bug in slingshot forces us to catch Throwable for HTTP errors, 
+                                           ;; https://github.com/scgilardi/slingshot/issues/60
+                                           ;; this can also be resolved by refactoring morse to be more lean
+                                                          (catch Throwable e
                                                             (debug "error sending telegram message:" e)
                                                             e))))
                     (recur (<? S send-text))))
@@ -123,7 +126,7 @@
                                            :type :ie.simm.languages.chat/send-photo-reply
                                            :response (try
                                                        (t/send-photo (:telegram-bot-token config) chat-id url)
-                                                       (catch Exception e
+                                                       (catch Throwable e
                                                          (debug "error sending telegram photo:" e)
                                                          e))))
                     (recur (<? S send-photo))))
@@ -135,7 +138,7 @@
                                            :type :ie.simm.languages.chat/send-document-reply
                                            :response (try
                                                        (t/send-document (:telegram-bot-token config) chat-id url)
-                                                       (catch Exception e
+                                                       (catch Throwable e
                                                          (debug "error sending telegram document:" e)
                                                          e))))
                     (recur (<? S send-document))))

diff --git a/src/ie/simm/simmie.clj b/src/ie/simm/simmie.clj
@@ -1,7 +1,7 @@
 (ns ie.simm.simmie
   (:require [taoensso.timbre :as log]
             [taoensso.timbre.appenders.core :as appenders]
-            [superv.async :refer [S go-try <? <??] :as sasync]
+            [superv.async :refer [S go-try <? <?? on-abort] :as sasync]
             [ie.simm.http :refer [ring-handler]]
             [ring.adapter.jetty :refer [run-jetty]]
             [clojure.core.async :refer [chan close!]]
@@ -30,8 +30,7 @@
                                                     (swap! peer assoc-in [:http :server] server)
                                                     (log/info "Server started.")
                                                     ;; this only unblocks on crash
-                                                    (<? S (chan))
-                                                    (.stop server))))
+                                                    (on-abort S (.stop server)))))
                                   :delay (* 10 1000)
                                   :log-fn (fn [level msg] (log/log level msg)))
     (log/info "Server started.")