-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async iterable<T>
type to WebIDL
#1397
Open
lucacasonato
wants to merge
28
commits into
whatwg:main
Choose a base branch
from
lucacasonato:async_iterator_type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
14f1bdb
Add `async iterable<T>` type to WebIDL
lucacasonato b7df167
Reason argument for close async iterable
lucacasonato 0402e85
fix typo
lucacasonato b6f7392
clarify the details of allowed positions for async iterables
lucacasonato 6363f6c
fix ci
lucacasonato 5533589
iterable -> iterable + iterator
lucacasonato 6559e06
fixes
lucacasonato 3789832
Merge remote-tracking branch 'origin/main' into async_iterator_type
lucacasonato 6f284c1
fix
lucacasonato dcbe738
fix
lucacasonato bd86c51
fix
lucacasonato f97033b
Fix typo
MattiasBuelens 30fb12d
Fix link text
MattiasBuelens 3469138
Fix duplicate dfn
MattiasBuelens 947fb78
Fix link id
MattiasBuelens 118b446
Simplify
MattiasBuelens ca5967b
Merge pull request #1 from MattiasBuelens/async_iterator_type
lucacasonato 11f9a9f
review comments
lucacasonato dc07972
fix
lucacasonato dd56f97
an
lucacasonato 9a79b42
fixes
lucacasonato 6374863
review comments
lucacasonato 70e9646
wip
lucacasonato 3c5164a
Merge remote-tracking branch 'origin/main' into async_iterator_type
lucacasonato df3ec8d
fix up overload resolution + union for string object special case
lucacasonato 5a0bb8e
[=Iterator Record=]
lucacasonato df8383f
close an async iterator |reason|
lucacasonato 1b6489e
Update index.bs
lucacasonato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For consistency with elsewhere (including within this PR), I guess we should use
<emu-val>undefined</emu-val>
here and below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you're still missing the instance two lines below.