Make URL's origin return solely ASCII code points #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/html#2568 for discussion. See whatwg/html#2689 for the corresponding change to the HTML Standard. Closes #297.
zcorpan
reviewed
May 17, 2017
|
|
||
| <p class="note no-backref">It returns the Unicode rather than the ASCII serialization for | ||
| compatibility with HTML's <code>MessageEvent</code> feature. [[!HTML]] | ||
| <a lt="serialization of an origin">serialization</a> of <a>context object</a>'s <a for=URL>url</a>'s |
There was a problem hiding this comment.
This seems to be a link error; no link in the preview...
There was a problem hiding this comment.
Yeah, it needs HTML to land first and then Shepherd needs to pick up the new link.
zcorpan
approved these changes
May 17, 2017
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 17, 2017
Follows whatwg/url#311. This is both a spec update and a public API change.
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 18, 2017
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes #2568.
|
Tests at web-platform-tests/wpt#5944. |
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 26, 2017
Follows whatwg/url#311. This is both a spec update and a public API change.
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
May 26, 2017
Follows whatwg/url#311. This is both a spec update and a public API change.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
And rename “ASCII serialization of an origin” to “serialization of an origin” though allow both to be used. Not all implementations implemented the Unicode variant and the ones that did, did so in a way that made it hard to use. Tests: * web-platform-tests/wpt#5939 * web-platform-tests/wpt#5940 * web-platform-tests/wpt#5941 * web-platform-tests/wpt#5944 * web-platform-tests/wpt#5946 * web-platform-tests/wpt#5955 * web-platform-tests/wpt#5957 * web-platform-tests/wpt#5958 URL Standard change: whatwg/url#311. Service Worker specification follow-up issue: w3c/ServiceWorker#1142. Fixes whatwg#2568.
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Follows whatwg/url#311 Rename previous origin serializer to origin_unicode()
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#2568 for discussion.
See whatwg/html#2689 for the corresponding
change to the HTML Standard.
Closes #297.
Preview | Diff