Update for changes to HTML's structured cloning/transferring #722
Conversation
index.bs
Outdated
| useful for scenarios where both branches are to be consumed in such a way that they might otherwise interfere with each | ||
| other, such as by <a abstract-op lt="Transfer">transfering</a> their <a>chunks</a>. However, it does introduce a | ||
| noticable asymmetry between the two branches. [[!HTML]] | ||
| other, such as by <a href="#transfer-array-buffer">transfering</a> their <a>chunks</a>. However, it does introduce a |
There was a problem hiding this comment.
This defines transfering by linking to TransferArrayBuffer, which asserts its argument has an [[ArrayBufferData]] internal slot, but this section is talking about arbitrary chunks. I guess ArrayBuffer views are the primary (sole?) example that is both cloneable and then transferable, but it made me double-take.
There was a problem hiding this comment.
This sub-clause of the sentence is "such as", so yeah, it's just giving an example of how branches could interfere with each other.
There was a problem hiding this comment.
I'll link to HTML's "transferable objects" instead
index.bs
Outdated
| useful for scenarios where both branches are to be consumed in such a way that they might otherwise interfere with each | ||
| other, such as by <a abstract-op lt="Transfer">transfering</a> their <a>chunks</a>. However, it does introduce a | ||
| noticable asymmetry between the two branches. [[!HTML]] | ||
| other, such as by <a href="#transfer-array-buffer">transfering</a> their <a>chunks</a>. However, it does introduce a |
| @@ -101,7 +101,7 @@ exports.PromiseInvokeOrPerformFallback = (O, P, args, F, argsF) => { | |||
| }; | |||
|
|
|||
| // Not implemented correctly | |||
| exports.SameRealmTransfer = O => O; | |||
| exports.TransferArrayBuffer = O => O; | |||
There was a problem hiding this comment.
How about using O => O.slice(0) instead? Or has this already been discussed?
There was a problem hiding this comment.
In general this could probably be a lot better; that's a reasonable start.
|
lgtm |
Closes #701.
This is basically editorial so if people are busy no need to review this; I'll merge it in a few days. But as always review is nice.